Make FakeScheduler less flaky #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
force-pushed
the
fakescheduler
branch
8 times, most recently
from
e01a9db
to
8c7e2b8
Compare
chrisdunelm
approved these changes
Oct 12, 2016
| }); | ||
| } | ||
|
|
||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -88,7 +82,8 @@ public PollSource(TimeSpan timeToCompletion, int finalResult) | |||
| FinalResult = finalResult; | |||
| } | |||
|
|
|||
| private int Poll(CallSettings callSettings) => Clock.GetCurrentDateTimeUtc() < CompletionTime ? 0 : FinalResult; | |||
| private int Poll(CallSettings callSettings) => | |||
| Clock.GetCurrentDateTimeUtc() < CompletionTime? 0 : FinalResult; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
|
|
||
| /// <summary> | ||
| /// Shorthand method for "run for a logical day". See <see cref="RunUntil(DateTime)"/> for details. | ||
| /// <para> | ||
| /// Invokes the given action in a separate thread, and then runs the scheduler until of four conditions is met: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
We now don't have the flaky "pause" at various points. This does mean that any scheduled actions can easily overlap each other in real time, but it's hard to fix that without flakiness. If it becomes an issue, we can add a configurable pause. The API is now consistent and more clearly documented, and has a couple of "guard" methods to prevent Run being called accidentally instead of RunAsync. (I found I consistently made that error.) For some reason they fail - only on Travis - if run in parallel. That shouldn't be the case, and I'll file a new issue about it, but it can wait for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now don't have the flaky "pause" at various points. This does mean that any scheduled actions can easily overlap each other in real time, but it's hard to fix that without flakiness. If it becomes an issue, we can add a configurable pause.
The API is now consistent and more clearly documented, and
has a couple of "guard" methods to prevent Run being called
accidentally instead of RunAsync. (I found I consistently made that
error.)