Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2/apierror): use errors.As in FromError #189

Merged
merged 1 commit into from
May 5, 2022
Merged

fix(v2/apierror): use errors.As in FromError #189

merged 1 commit into from
May 5, 2022

Conversation

noahdietz
Copy link
Contributor

Now that v2 is on go 1.15 we can use errors.

@noahdietz noahdietz requested a review from a team as a code owner May 5, 2022 21:35
codyoss
codyoss approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@noahdietz noahdietz merged commit f30f05b into googleapis:main May 5, 2022
@noahdietz noahdietz deleted the use-errors branch May 5, 2022 22:13
@codyoss codyoss mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noahdietz @codyoss