Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ExtractProtoMessage to apierror #213

Merged
merged 15 commits into from
Aug 4, 2022
Merged

feat: add ExtractProtoMessage to apierror #213

merged 15 commits into from
Aug 4, 2022

Conversation

shollyman
Copy link
Contributor

Fixes: #212

@shollyman shollyman requested a review from noahdietz July 21, 2022 21:12
@shollyman shollyman requested a review from a team as a code owner July 21, 2022 21:12
quartzmo
quartzmo reviewed Jul 21, 2022
View reviewed changes
v2/apierror/apierror.go Outdated Show resolved Hide resolved
quartzmo
quartzmo reviewed Jul 22, 2022
View reviewed changes
v2/apierror/apierror.go Outdated Show resolved Hide resolved
quartzmo
quartzmo reviewed Jul 22, 2022
View reviewed changes
v2/apierror/apierror.go Outdated Show resolved Hide resolved
noahdietz
noahdietz reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me thanks for adjusting it.

v2/apierror/internal/proto/custom_error.proto Outdated Show resolved Hide resolved
v2/go.mod Outdated Show resolved Hide resolved
@noahdietz noahdietz requested a review from quartzmo August 3, 2022 23:32
@noahdietz
Copy link
Contributor

I'd like @quartzmo to review/Approve.

@shollyman shollyman changed the title feat: add ExtractMessage to apierror feat: add ExtractProtoMessage to apierror Aug 4, 2022
quartzmo
quartzmo reviewed Aug 4, 2022
View reviewed changes
v2/apierror/apierror.go Outdated Show resolved Hide resolved
quartzmo
quartzmo approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! (with optional nits)

v2/apierror/internal/proto/custom_error.proto Outdated Show resolved Hide resolved
v2/apierror/internal/proto/custom_error.proto Outdated Show resolved Hide resolved
@shollyman shollyman enabled auto-merge (squash) August 4, 2022 17:51
@shollyman shollyman merged commit a6ce70c into googleapis:main Aug 4, 2022
@release-please release-please bot mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz left review comments

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apierror: simplify extraction of custom errors
3 participants
@shollyman @noahdietz @quartzmo