feat(v2): add GoVersion package variable #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
Jun 7, 2023
noahdietz
changed the title
codyoss
approved these changes
Jun 8, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
🤖 I have created a release *beep* *boop* --- ## [2.11.0](https://togithub.com/googleapis/gax-go/compare/v2.10.0...v2.11.0) (2023-06-13) ### Features * **v2:** add GoVersion package variable ([#283](https://togithub.com/googleapis/gax-go/issues/283)) ([26553cc](https://togithub.com/googleapis/gax-go/commit/26553ccadb4016b189881f52e6c253b68bb3e3d5)) ### Bug Fixes * **v2:** handle space in non-devel go version ([#288](https://togithub.com/googleapis/gax-go/issues/288)) ([fd7bca0](https://togithub.com/googleapis/gax-go/commit/fd7bca029a1c5e63def8f0a5fd1ec3f725d92f75)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
GoVersionpackage variable that is populated oninitwith an internalgoVersionmethod. ThisgoVersionmethod is a copy of theversionGomethod, which was generated in every GAPIC. Once this is released, we can removeversionGofrom every GAPIC while migrating all to use thisGoVersion(googleapis/gapic-generator-go#1299)Note: The
goVersionimplementation was copied directly from the generatedversionGoexcept for one caveat. When the runtime version is a prerelease and already contains a dash-separator, we don't need to include another one when concatenating the semver and prerelease strings.