feat(v2/callctx): add new callctx package #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new callctx package to gax to facilitate adding and retrieving values from context.Context that our libraries can use to share information throughout the call stack. The first addition to this package will be two APIs to allow users to set RPC headers that will be added to API requests our clients make. A follow up PR will be made to add using these after these changes are merged with googleapis#290.
noahdietz
approved these changes
Jun 23, 2023
quartzmo
reviewed
Jun 23, 2023
Should we just submit this and update 290 to leverage these as well? The way I see it, this PR provides users a transport-agnostic means of setting headers, but 290, the transport-specific helpers, need to still respect users that have set |
quartzmo
reviewed
Jun 23, 2023
quartzmo
reviewed
Jun 23, 2023
codyoss
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
tritone
added a commit
to tritone/google-api-go-client
that referenced
this pull request
Jul 5, 2023
This allows headers added to the context metadata to be applied to the request. See googleapis/gax-go#291.
tritone
added a commit
to googleapis/google-api-go-client
that referenced
this pull request
Jul 7, 2023
This allows headers added to the context metadata to be applied to the request. See googleapis/gax-go#291.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new callctx package to gax to facilitate adding and retrieving values from context.Context that our libraries can use to share information throughout the call stack. The first addition to this package will be two APIs to allow users to set RPC headers that will be added to API requests our clients make.
A follow up PR will be made to add using these after these changes are merged with #290.