Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max-retry-count to stop retries #315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Tulsishah
Copy link

@Tulsishah Tulsishah commented Dec 29, 2023

To prevent continuous retries in case of errors, the MaxRetryCount variable serves as a checkpoint. It specifies the maximum allowable attempts before terminating the retry process.

Issue: #316

@Tulsishah Tulsishah requested a review from a team as a code owner December 29, 2023 07:04
Copy link

conventional-commit-lint-gcf bot commented Dec 29, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

// To prevent continuous retries in case of errors, the MaxRetryCount variable
// serves as a checkpoint. It specifies the maximum allowable attempts before
// terminating the retry process.
MaxRetryCount int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open an issue about this first, also it seems like there is likely some missing files in this commit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: #316
It seems like there is likely some missing files in this commit? --> Could you please help to update ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm encountering an issue where test files indicate a need for updates, but the variable in question isn't directly used in any functions. Could you please advise on where to focus the updates?

@Tulsishah Tulsishah requested a review from codyoss January 2, 2024 16:02
@Tulsishah Tulsishah changed the title feat: Max-retry-count to stop retries max-retry-count to stop retries Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants