This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
InstantiatingGrpcChannelProvider requires ScheduledExecutorService for no good reason #1055
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
The InstantiatingGrpcChannelProvider.withExecutor method requires
ScheduledExecutorService
, and similarly the InstantiatingGrpcChannelProvider$Builder. setExecutorProvider requires a ExecutorProvider(which providesScheduledExecutorService
), but this requirement seems overly strict, because the executor is only used for ManagedChannelBuilder.executor, which takesExecutor
rather thanScheduledExecutorService
.This unnecessary restriction prevents users from providing a more performant executor (e.g. ForkJoinPool) than
ScheduledThreadPoolExecutor
when building a gRPC channel.The text was updated successfully, but these errors were encountered: