Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass request in ApiTracer #1491

Merged
merged 7 commits into from Oct 27, 2021
Merged

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Sep 24, 2021

Pass request and response in ApiTracer attemptStarted and attemptSucceeded so we could annotated metrics with additional information in the requests/responses.

@mutianf mutianf requested review from as code owners Sep 24, 2021
@google-cla google-cla bot added the cla: yes label Sep 24, 2021
@Neenu1995 Neenu1995 added the release-please:force-run label Oct 8, 2021
@release-please release-please bot removed the release-please:force-run label Oct 8, 2021
@mutianf mutianf marked this pull request as draft Oct 27, 2021
@mutianf mutianf marked this pull request as ready for review Oct 27, 2021
@igorbernstein2 igorbernstein2 changed the title feat: pass request or response in ApiTracer feat: pass request in ApiTracer Oct 27, 2021
@igorbernstein2 igorbernstein2 merged commit 27bf265 into googleapis:main Oct 27, 2021
5 checks passed
@mutianf mutianf deleted the api_tracer branch Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants