Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

feat: pass request in ApiTracer#1491

Merged
igorbernstein2 merged 7 commits into
googleapis:mainfrom
mutianf:api_tracer
Oct 27, 2021
Merged

feat: pass request in ApiTracer#1491
igorbernstein2 merged 7 commits into
googleapis:mainfrom
mutianf:api_tracer

Conversation

@mutianf

@mutianf mutianf commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Pass request and response in ApiTracer attemptStarted and attemptSucceeded so we could annotated metrics with additional information in the requests/responses.

@mutianf mutianf requested review from a team September 24, 2021 13:52
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
@Neenu1995 Neenu1995 added the release-please:force-run To run release-please label Oct 8, 2021
@release-please release-please Bot removed the release-please:force-run To run release-please label Oct 8, 2021
@mutianf mutianf marked this pull request as draft October 27, 2021 15:36
@mutianf mutianf marked this pull request as ready for review October 27, 2021 15:40
@igorbernstein2 igorbernstein2 changed the title feat: pass request or response in ApiTracer feat: pass request in ApiTracer Oct 27, 2021
@igorbernstein2 igorbernstein2 merged commit 27bf265 into googleapis:main Oct 27, 2021
@mutianf mutianf deleted the api_tracer branch October 27, 2021 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants