Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

properly format error string #430

Merged
merged 1 commit into from
Dec 4, 2017
Merged

properly format error string #430

merged 1 commit into from
Dec 4, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Nov 23, 2017

Logger uses braces for placeholders, not %s.

Logger uses braces for placeholders, not %s.
@codecov-io
Copy link

codecov-io commented Nov 23, 2017

Codecov Report

Merging #430 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #430   +/-   ##
=========================================
  Coverage     70.53%   70.53%           
  Complexity      634      634           
=========================================
  Files           136      136           
  Lines          2912     2912           
  Branches        220      220           
=========================================
  Hits           2054     2054           
  Misses          776      776           
  Partials         82       82
Impacted Files Coverage Δ Complexity Δ
...va/com/google/api/gax/core/PropertiesProvider.java 42.1% <ø> (ø) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b86a50...64427a4. Read the comment docs.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit 89ddbc7 into googleapis:master Dec 4, 2017
@pongad pongad deleted the fix-format branch December 4, 2017 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants