Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Update build to use gradle apis for file paths. #434

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

igorbernstein2
Copy link
Contributor

This allows individual tests to be run using intellij's gradle runner. Otherwise they fail to find the version file

…l tests to be run using intellij's gradle runner.
@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #434   +/-   ##
=========================================
  Coverage     70.53%   70.53%           
  Complexity      634      634           
=========================================
  Files           136      136           
  Lines          2912     2912           
  Branches        220      220           
=========================================
  Hits           2054     2054           
  Misses          776      776           
  Partials         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b86a50...1da8380. Read the comment docs.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see there are other places using "new File" - should we update the rest of them too? Your change implies that file(...) is more idiomatic in Gradle.

@garrettjonesgoogle garrettjonesgoogle merged commit a99c8fb into googleapis:master Nov 30, 2017
@igorbernstein2
Copy link
Contributor Author

I'm not a gradle expert, but I think so. I only fixed the places that prevented me from iterating quickly on the streaming callable

@igorbernstein2 igorbernstein2 deleted the ssc-0-prep branch January 10, 2018 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants