Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Remove RetryCallable from the chain when it's disabled #450

Merged

Conversation

igorbernstein2
Copy link
Contributor

This is necessary when writing manual clients that handle their own retries: the exception wrapping is necessary, but retry callable gets in the way

@codecov-io
Copy link

codecov-io commented Dec 30, 2017

Codecov Report

Merging #450 into master will decrease coverage by 0.22%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #450      +/-   ##
============================================
- Coverage     71.94%   71.72%   -0.23%     
  Complexity      746      746              
============================================
  Files           154      154              
  Lines          3329     3331       +2     
  Branches        256      258       +2     
============================================
- Hits           2395     2389       -6     
- Misses          837      844       +7     
- Partials         97       98       +1
Impacted Files Coverage Δ Complexity Δ
...a/com/google/api/gax/grpc/GrpcCallableFactory.java 69.23% <33.33%> (-2.77%) 8 <0> (+1)
.../java/com/google/api/gax/grpc/GrpcCallContext.java 71.01% <0%> (-8.7%) 21% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532aae0...6bf215f. Read the comment docs.

@garrettjonesgoogle
Copy link
Member

How difficult would it be to add a test for this change?

@igorbernstein2
Copy link
Contributor Author

I can't really think of anything simple...I can try to write a unit test that compares the relative performance of a callable with maxAttempts=0 and totalTimeout=0.00001, but I think that will be a bit too flaky

@garrettjonesgoogle
Copy link
Member

Ok, don't worry about it then.

@garrettjonesgoogle garrettjonesgoogle merged commit 90103e5 into googleapis:master Jan 3, 2018
@igorbernstein2 igorbernstein2 deleted the disable-retries branch January 5, 2018 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants