Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Update benchmarks #478

Merged
merged 5 commits into from
Feb 23, 2018
Merged

Update benchmarks #478

merged 5 commits into from
Feb 23, 2018

Conversation

igorbernstein2
Copy link
Contributor

  • update existing benchmarks to use jmh instead caliper
  • add benchmarks for ServerStreamingCallable

I wanted to start benchmarking the ServerStreamingCallable code I've been working on but it seems like the current benchmarks don't run anymore. It seems like caliper stopped publishing binaries and I couldn't get the version used by gax to work (not to mention that it's extremely old). Instead I ported the benchmarks to JMH.

@igorbernstein2
Copy link
Contributor Author

@pongad, would you mind reviewing?

@codecov-io
Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #478 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #478   +/-   ##
=========================================
  Coverage     70.34%   70.34%           
  Complexity      773      773           
=========================================
  Files           162      162           
  Lines          3672     3672           
  Branches        275      275           
=========================================
  Hits           2583     2583           
  Misses          973      973           
  Partials        116      116

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b4666...4376403. Read the comment docs.

@pongad pongad self-requested a review February 12, 2018 01:41
@pongad pongad merged commit b8eda69 into googleapis:master Feb 23, 2018
@igorbernstein2 igorbernstein2 deleted the benchmarks-wip branch March 18, 2018 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants