Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Allow null HttpResponseParser #511

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Mar 24, 2018

Some API methods have no response object, so the response parser for that method descriptor should be null.

Also check for right Http method when server is determing which method to run on a request.

@andreamlin
Copy link
Contributor Author

PTAL

@codecov-io
Copy link

codecov-io commented Mar 24, 2018

Codecov Report

Merging #511 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #511      +/-   ##
============================================
- Coverage     71.63%   71.57%   -0.06%     
  Complexity      836      836              
============================================
  Files           169      169              
  Lines          3853     3856       +3     
  Branches        292      293       +1     
============================================
  Hits           2760     2760              
- Misses          963      966       +3     
  Partials        130      130
Impacted Files Coverage Δ Complexity Δ
.../google/api/gax/httpjson/HttpJsonCallSettings.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...m/google/api/gax/httpjson/ApiMethodDescriptor.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...m/google/api/gax/httpjson/HttpRequestRunnable.java 62.31% <0%> (-2.84%) 4 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d54729...e4e8dd7. Read the comment docs.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit d0196bb into googleapis:master Mar 26, 2018
@andreamlin andreamlin deleted the otherChanges branch March 26, 2018 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants