Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Allow credentials to be nullable in HttpJsonCallOptions #518

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

andreamlin
Copy link
Contributor

This allows generated unit tests, which don't have credentials set, to still be able to create the tested client object.

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #518   +/-   ##
=========================================
  Coverage     72.64%   72.64%           
  Complexity      853      853           
=========================================
  Files           169      169           
  Lines          3864     3864           
  Branches        294      294           
=========================================
  Hits           2807     2807           
  Misses          914      914           
  Partials        143      143
Impacted Files Coverage Δ Complexity Δ
...m/google/api/gax/httpjson/HttpJsonCallOptions.java 50% <ø> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a775045...3c13614. Read the comment docs.

@andreamlin
Copy link
Contributor Author

PTAL

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit 2e782a3 into googleapis:master Mar 29, 2018
@andreamlin andreamlin deleted the nullHttpCredentials branch March 5, 2019 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants