Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back helper for generating "parent" path #873

Open
bcoe opened this issue Oct 28, 2019 · 5 comments
Open

feat: add back helper for generating "parent" path #873

bcoe opened this issue Oct 28, 2019 · 5 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bcoe
Copy link
Contributor

bcoe commented Oct 28, 2019

In v3 of the translate API, we are requiring that folks generate a full parent path when interacting with the API:

parent: `projects/${projectId}/locations/${location}`,

This is fairly unwieldy, and we should reintroduce a helper for this.

CC: @alexander-fenster, @nnegrey

@alexander-fenster
Copy link
Contributor

Will be later this week. This will be a compatible change (just adding a few methods). @xiaozhenliu-gg5 is working on it in the generator.

@arcman77
Copy link

When I look at my project storage bucket in the gcp (or if I query the bucket's metadata from the command line) the value for the location field just says "us (multiple regions in United States)" (or "US")

Am I supposed to assume that it should be "us-central1"?

@nnegrey
Copy link

nnegrey commented Nov 12, 2019

@arcman77, feel free to open a separate issues for this as that is a little different, but there are different types of cloud storage buckets.
Regions and multi-regions. Sounds like you have a multi-regional bucket.
https://cloud.google.com/storage/docs/locations#available_locations

The translation api currently supports two regions (global and us-central1)
"""
Note: All your resources in a single request to Translation API - Advanced must have the same location. Currently, only global and us-central1 locations are supported. For all custom resources—AutoML models, glossaries, long-running-operations—you must use us-central1. You can also use us-central1 for general translation and language detection. The global location can only be used for general translation models and language detection.
"""
From https://cloud.google.com/translate/docs/migrate-to-v3#resources_projects_and_locations

But the bucket location is only required if you are trying to use custom resources, if you are not, then global should be all you need.

@JustinBeckwith JustinBeckwith transferred this issue from googleapis/nodejs-translate Jul 15, 2020
@JustinBeckwith
Copy link
Contributor

Moving this over to gax since I suspect this would need to be fixed there?

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 15, 2020
@bcoe bcoe added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 15, 2020
@yoshi-automation yoshi-automation removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jul 15, 2020
@alexander-fenster
Copy link
Contributor

I guess it's the gapic-generator-typescript and maybe it's just a dup of googleapis/gapic-generator-typescript#570, but I'll take a look anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

6 participants