New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up grpc error handling and integration test for promote error info field #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 20, 2021
summer-ji-eng
changed the title
fix: clean up grpc error handling and integeration test for promote error info field
fix: clean up grpc error handling and integration test for promote error info field
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please don't release this until you verified that Ads libraries work. We can make a pre-release and ask Ads folks to check it.
alexander-fenster
approved these changes
Sep 22, 2021
summer-ji-eng
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Sep 22, 2021
Checked with Ads team. It works as expected. |
summer-ji-eng
added
automerge
Merge the pull request once unit tests and other checks pass.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Oct 1, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up googleError class
Changes:
Add
errorInfoMetadata
placeholder forerrorInfo.metadata
, same aserrorInfo.reason
,errorInfo.domain
. Replace previously add error info metadata key-value pair into the existing metadata.Reasons:
metadata
occupied for gRPC metadata, we have to rename for ErrorInfo's metadata.metadata
, it is still hard for user figure out the which keys are from gRPC metadata, which keys are from ErrorInfo.Wrapped the decoding in
GoogleError.parseGRPCStatusDetails
. Movedcaller.ts
to import GoogleErrorDecode, and handle the metadata key.Add a test for situation of
GoogleAdsFailure
. It also sent it in gRPC metadata. In gax, we still decode details ignore theGoogleAdsFailure
.