Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable testing of grpc-js #400

Merged
merged 14 commits into from
Feb 8, 2019
Merged

test: enable testing of grpc-js #400

merged 14 commits into from
Feb 8, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jan 27, 2019

This starts enabling the tests with grpc-js. Only problem is.... they fail right now! @alexander-fenster are you cool with taking this PR over and getting the tests to pass?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2019
@alexander-fenster
Copy link
Contributor

Yes! From what I see, the only two tests that fail use unsupported API. As far as I know, the corresponding functionality now exists in @grpc/proto-loader, so @eoogbe or I will work on a code change to make it work (will be somewhat similar to #291, which was then reverted by #301).

@alexander-fenster
Copy link
Contributor

With my last commit, unit tests should pass. To make system tests work, first of all we need to refactor grpc-js a little bit, it must not use getRequestMetadata from the auth library as it's deprecated, and we get deprecation warning.

https://github.com/grpc/grpc-node/blob/494b97ac1a58a942714c6fea0990ba690888f626/packages/grpc-js/src/index.ts#L55-L65

I will take care of that.

@alexander-fenster
Copy link
Contributor

Related PR for grpc-js: grpc/grpc-node#723

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Feb 7, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Feb 7, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 7, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@JustinBeckwith JustinBeckwith merged commit 727565e into master Feb 8, 2019
@alexander-fenster alexander-fenster deleted the grpcjs branch April 24, 2019 20:50
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants