Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more information for exceed timeout error #839

Merged
merged 11 commits into from
Jun 2, 2020
Merged

feat: more information for exceed timeout error #839

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3701d12
more informtion for exceed timeout error
xiaozhenliu-gg5 Jun 1, 2020
e057733
fix
xiaozhenliu-gg5 Jun 1, 2020
08f9ca8
add unit test
xiaozhenliu-gg5 Jun 2, 2020
b3963ad
feedback
xiaozhenliu-gg5 Jun 2, 2020
0794afc
reformat error message
xiaozhenliu-gg5 Jun 2, 2020
e55dd46
Merge branch 'master' into retry-info
xiaozhenliu-gg5 Jun 2, 2020
6cfaea8
pass api name to create api call
xiaozhenliu-gg5 Jun 2, 2020
6eea4ff
Merge branch 'retry-info' of github.com:googleapis/gax-nodejs into re…
xiaozhenliu-gg5 Jun 2, 2020
6cefacc
Merge branch 'master' into retry-info
xiaozhenliu-gg5 Jun 2, 2020
3691536
lint
xiaozhenliu-gg5 Jun 2, 2020
f1a8b26
add service name from construction
xiaozhenliu-gg5 Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/normalCalls/retries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ export function retryable(
let timeoutId: ReturnType<typeof setTimeout> | null;
let now = new Date();
let deadline: number;
const startTime = now.getTime();
if (retry.backoffSettings.totalTimeoutMillis) {
deadline = now.getTime() + retry.backoffSettings.totalTimeoutMillis;
deadline = startTime + retry.backoffSettings.totalTimeoutMillis;
}
let retries = 0;
const maxRetries = retry.backoffSettings.maxRetries!;
Expand All @@ -80,8 +81,10 @@ export function retryable(
function repeat() {
timeoutId = null;
if (deadline && now.getTime() >= deadline) {
const timeCost = now.getTime() - startTime;
const funcName = func.name;
const error = new GoogleError(
'Retry total timeout exceeded before any response was received'
`${funcName} takes ${timeCost} milliseconds which exceeds retry total timeout ${retry.backoffSettings.totalTimeoutMillis} milliseconds before any response was received. The retry settings is ${retry.backoffSettings}.`
);
error.code = Status.DEADLINE_EXCEEDED;
callback(error);
Expand Down