Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow callOptions.retry settings with grpc streaming calls #901

Merged

Conversation

AVaksman
Copy link
Contributor

Currently if user passes custom CallOptions.retry settings to a function that employs grpc streaming call, the API will throw

TypeError: stream.on is not a function

from this line

stream.on(event, this.emit.bind(this, event));

due to GRPCCall func being wrapped in retryable

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #901 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
+ Coverage   88.45%   88.46%   +0.01%     
==========================================
  Files          41       41              
  Lines        6546     6555       +9     
  Branches      564      567       +3     
==========================================
+ Hits         5790     5799       +9     
  Misses        752      752              
  Partials        4        4              
Impacted Files Coverage Δ
src/createApiCall.ts 98.41% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963c714...c160976. Read the comment docs.

@AVaksman AVaksman force-pushed the callOptionsj_retry_streams branch 2 times, most recently from 9ab706d to c9c277f Compare September 15, 2020 03:15
@AVaksman AVaksman changed the title allow callOptions.retry settings with grpc streaming calls fix: allow callOptions.retry settings with grpc streaming calls Sep 15, 2020
@AVaksman AVaksman marked this pull request as ready for review September 16, 2020 22:28
@AVaksman AVaksman requested a review from a team as a code owner September 16, 2020 22:28
@AVaksman AVaksman force-pushed the callOptionsj_retry_streams branch 2 times, most recently from ce9aa0f to 2fa6401 Compare September 17, 2020 19:05
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 533de29 into googleapis:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants