Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: release v2.11.3-pre, tag next, with proto3 optional support #978

Closed
wants to merge 2 commits into from

Conversation

alexander-fenster
Copy link
Contributor

No description provided.

@alexander-fenster alexander-fenster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 9, 2021
@alexander-fenster alexander-fenster requested a review from a team as a code owner April 9, 2021 04:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #978 (a4cdd19) into master (889730c) will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   88.58%   88.22%   -0.37%     
==========================================
  Files          43       43              
  Lines        7098     7098              
  Branches      563      603      +40     
==========================================
- Hits         6288     6262      -26     
- Misses        799      825      +26     
  Partials       11       11              
Impacted Files Coverage Δ
src/fallback.ts 75.70% <0.00%> (-3.58%) ⬇️
src/streamingCalls/streamingApiCaller.ts 90.42% <0.00%> (-2.13%) ⬇️
src/transcoding.ts 95.74% <0.00%> (-1.22%) ⬇️
src/streamingCalls/streaming.ts 93.71% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889730c...a4cdd19. Read the comment docs.

@alexander-fenster
Copy link
Contributor Author

protobuf.js v6.11.0 contains this change and should be pulled automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant