Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover org rename: googlecloudplatform -> googleapis #217

Merged
merged 1 commit into from Sep 20, 2018

Conversation

dwsupplee
Copy link
Contributor

@dwsupplee dwsupplee added the type: docs Improvement to the documentation for an API. label Sep 20, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2018
@dwsupplee dwsupplee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 20, 2018
@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #217 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #217      +/-   ##
=========================================
+ Coverage   84.69%   84.7%   +<.01%     
=========================================
  Files          64      64              
  Lines        2470    2471       +1     
=========================================
+ Hits         2092    2093       +1     
  Misses        378     378
Impacted Files Coverage Δ
src/ApiCore/RetrySettings.php 98.09% <ø> (ø) ⬆️
src/ApiCore/GapicClientTrait.php 87.83% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7bac8...a3f0abe. Read the comment docs.

@dwsupplee dwsupplee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 20, 2018
@dwsupplee
Copy link
Contributor Author

This is good to go :)

@michaelbausor michaelbausor merged commit 21e6c28 into googleapis:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants