[gax-php] feat: add REST headers #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bshaffer
reviewed
May 4, 2021
| @@ -64,6 +64,7 @@ public static function buildAgentHeader($headerInfo) | |||
| // - gapicVersion (gapic/) | |||
| // - apiCoreVersion (gax/) | |||
| // - grpcVersion (grpc/) | |||
| // - restVersion (rest/) | |||
There was a problem hiding this comment.
Don't forget to add this to the $headerInfo phpdoc for the method!
src/GapicClientTrait.php
Outdated
| // a REST-only library, then the grpcVersion header should not be set. | ||
| if ($this->transport instanceof GrpcFallbackTransport) { | ||
| $options['grpcVersion'] = phpversion('grpc'); | ||
| $options['restVersion'] = Version::getApiCoreVersion(); |
There was a problem hiding this comment.
As GrpcFallbackTransport doesn't actually use the grpc extension (or grpc), I'm not sure we want to set the grpc/ header, as it's most likely going to be empty.
dwsupplee
reviewed
May 5, 2021
dwsupplee
suggested changes
May 5, 2021
Co-authored-by: David Supplee <dwsupplee@gmail.com>
dwsupplee
approved these changes
May 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed primarily for REGAPIC. However, sending the REST header can also benefit gRPC and REST GAPIC libraries (the default) as well, since we don't support gRPC-only libraries.
Using gax-php's version as the default REST version.