New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow ServiceAccountJwtAccessCredentials to sign scopes #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 14, 2021
bshaffer
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 14, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/gapic-generator-php
that referenced
this pull request
Jul 29, 2021
bshaffer
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 17, 2021
dwsupplee
approved these changes
Aug 20, 2021
bshaffer
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Aug 20, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Aug 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
google/auth
version incomposer.json
to the new tag (v1.16.0)'useJwtAccessWithScopes' => false
togapic-generator-php
for DIREGAPIC APIs (done in feat: implement jwt access option gapic-generator-php#309)Note: These steps are now optional because Compute does not need the exclusion for Self-Signed JWTs with Scopes
google/cloud-compute
google/gax
)