Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow ServiceAccountJwtAccessCredentials to sign scopes #326

Merged
merged 9 commits into from Aug 20, 2021

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jun 14, 2021

TODO

Note: These steps are now optional because Compute does not need the exclusion for Self-Signed JWTs with Scopes

@bshaffer bshaffer requested a review from a team as a code owner June 14, 2021 17:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@bshaffer bshaffer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 14, 2021
gcf-merge-on-green bot pushed a commit to googleapis/gapic-generator-php that referenced this pull request Jul 29, 2021
@bshaffer bshaffer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 17, 2021
composer.json Outdated Show resolved Hide resolved
@bshaffer bshaffer added the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 908e073 into master Aug 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the implement-jwt-access-param branch August 20, 2021 23:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2021
@bshaffer bshaffer mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants