fix: ensure required query parameters with default values get sent over the wire #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bshaffer
approved these changes
Aug 18, 2021
| $query = Psr7\parse_query($request->getUri()->getQuery()); | ||
|
|
||
| $this->assertEquals('', $query['name']); | ||
| $this->assertEquals(0, $query['number']); |
There was a problem hiding this comment.
Just a question - what happens if no calls are made to setName and setNumber? Will the query param be empty or will the query parameter be omitted? And if that is the case, how will the API function?
There was a problem hiding this comment.
what happens if no calls are made to setName and setNumber? Will the query param be empty or will the query parameter be omitted?
If no calls are made to the message class, the test results would be the same. If a query parameter is determined to be required (by the generator implementation) it will always be added to the query string as long as an explicit value or default value are set.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows googleapis/gapic-generator-php@2d5ef58