Skip to content
This repository has been archived by the owner on Mar 20, 2018. It is now read-only.

Bundling sub-response handling is broken for actual proto objects #110

Closed
bjwatson opened this issue Jun 21, 2016 · 0 comments · Fixed by #111
Closed

Bundling sub-response handling is broken for actual proto objects #110

bjwatson opened this issue Jun 21, 2016 · 0 comments · Fixed by #111
Assignees
Labels

Comments

@bjwatson
Copy link
Contributor

bjwatson commented Jun 21, 2016

This line of code is invalid for proto repeated fields, which is what we're attempting to set as the sub-response field for bundling responses. This is the root cause of googleapis/google-cloud-python#1869.

We did not catch this earlier, because we are testing with named tuples. As part of this fix, we might want to switch our tests to use a simple proto object.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant