Skip to content
This repository has been archived by the owner on Mar 20, 2018. It is now read-only.

Do not try to ask for a bogus distribution #171

Merged

Conversation

lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Mar 4, 2017

The autogen code within GAX has an issue where it believes that gapic-google-longrunning-v1 is a real package, even though it is actually being vendored inside of GAX (unlike everything else). That makes the code that tries to add the gapic/x.y.z portion of the metrics header fail out.

For the moment, this code should be removed, as it raises an exception. Ultimately (when it is not a Saturday), OperationsClient should be given the value of the GAPIC that instantiates it.

Alternatively, we could split this out into a separate package for consistency, and track its version.

This PR:

Copy link
Contributor

@geigerj geigerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue to fix the underlying issue (i.e., either in the code generator, or by separating this package out)

@lukesneeringer
Copy link
Contributor Author

Done.

@lukesneeringer lukesneeringer merged commit 895fefd into googleapis:master Mar 6, 2017
@lukesneeringer lukesneeringer deleted the longrunning-package branch March 6, 2017 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants