Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fastFailMetadataRequest to use Promise.any #604

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor: fastFailMetadataRequest to use Promise.any #604

wants to merge 5 commits into from

Conversation

Dhoni77
Copy link

@Dhoni77 Dhoni77 commented Nov 13, 2023

Fixes #603 🦕

  • Use Promise.any instead of Promise.race
  • Update target library to es2021 in tsconfig.json

@Dhoni77 Dhoni77 requested a review from a team as a code owner November 13, 2023 06:42
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 13, 2023
danielbankhead
danielbankhead reviewed Nov 29, 2023
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 30, 2023
@danielbankhead danielbankhead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 30, 2023
@danielbankhead
Copy link
Member

Added do not merge until we upgrade to Node 16+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: fastFailMetadataRequest to use Promise.any
2 participants
@Dhoni77 @danielbankhead