feat: export headers to reduce duplication #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 97.77% 97.87% +0.09%
==========================================
Files 1 1
Lines 45 47 +2
Branches 7 7
==========================================
+ Hits 44 46 +2
Misses 1 1
Continue to review full report at Codecov.
|
|
Do you think it makes sense to Object.freeze() the headers object?
…On Wed, Feb 14, 2018, 1:43 PM Codecov ***@***.***> wrote:
Codecov
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33?src=pr&el=h1>
Report
Merging #33
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33?src=pr&el=desc>
into master
<https://codecov.io/gh/stephenplusplus/gcp-metadata/commit/51052001a6a1e2b4acb6287c5bdfe4b4ead1b420?src=pr&el=desc>
will *increase* coverage by 0.09%.
The diff coverage is 100%.
[image: Impacted file tree graph]
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33?src=pr&el=tree>
@@ Coverage Diff @@## master #33 +/- ##
==========================================+ Coverage 97.77% 97.87% +0.09%
==========================================
Files 1 1
Lines 45 47 +2
Branches 7 7
==========================================+ Hits 44 46 +2
Misses 1 1
Impacted Files
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33?src=pr&el=tree> Coverage
Δ
src/index.ts
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33/diff?src=pr&el=tree#diff-c3JjL2luZGV4LnRz> 97.87%
<100%> (+0.09%) ⬆️
------------------------------
Continue to review full report at Codecov
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33?src=pr&el=continue>
.
*Legend* - Click here to learn more
<https://docs.codecov.io/docs/codecov-delta>
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33?src=pr&el=footer>.
Last update 5105200...70210ef
<https://codecov.io/gh/stephenplusplus/gcp-metadata/pull/33?src=pr&el=lastupdated>.
Read the comment docs <https://docs.codecov.io/docs/pull-request-comments>
.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE0qdZWVdKzolMbBKuZ-OpFkMAds9Dmks5tUylVgaJpZM4SFyHP>
.
|
|
That's a fair call. Added! |
ofrobots
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this in response to the feedback here:
googleapis/google-auth-library-nodejs#284 (comment)