Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

chore: update license headers #256

Merged
merged 4 commits into from
Aug 16, 2019
Merged

chore: update license headers #256

merged 4 commits into from
Aug 16, 2019

Conversation

stephenplusplus
Copy link
Contributor

Builds were getting mad about these license headers!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2019
@stephenplusplus
Copy link
Contributor Author

@JustinBeckwith the header-check task is thrown off by the string-embedded license tag:

.jsdoc.js has an invalid copyright holder: Google LLC',

@JustinBeckwith
Copy link
Contributor

Hah. @chingor13 can you take a look?

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #256 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #256      +/-   ##
=========================================
+ Coverage   97.05%   97.1%   +0.04%     
=========================================
  Files           1       1              
  Lines         612     621       +9     
  Branches       87      87              
=========================================
+ Hits          594     603       +9     
  Misses         16      16              
  Partials        2       2
Impacted Files Coverage Δ
src/index.ts 97.1% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c59ee4...6bd59b4. Read the comment docs.

@chingor13
Copy link

Short term, googleapis/repo-automation-bots#30 should let this pass. Long term, we'll want to limit the search to the license header section. Filed googleapis/repo-automation-bots#32 to track

@JustinBeckwith JustinBeckwith merged commit 7a786c1 into master Aug 16, 2019
@stephenplusplus stephenplusplus deleted the spp--license branch August 16, 2019 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants