Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fields (claims?) needed in GoogleJsonWebSignature.cs's Payload class #1040

Closed
hoekma opened this issue Jun 19, 2017 · 1 comment
Closed
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. Type: Enhancement
Milestone

Comments

@hoekma
Copy link

hoekma commented Jun 19, 2017

JWT data is missing in the Payload instance returned from GoogleJsonWebSignature.ValidateAsync(). This is available in other languages' APIs based on this Google tutorial.

In a forked copy of the Google.Apis.Auth.GoogleJsonWebSignature, the following code in Google.ApisAuth.GoogleJsonWegbSignature.Payload class surfaced the missing data from the JWT, namely email, email_verified, name, picture, given_name, family_name, locale

Here is a link to a gist of my new Payload class' code :

https://gist.github.com/hoekma/7afa5444098a863d240ea2881e08bd53

P.S. I'm a little new to GitHub so let me know if there is a more appropriate way to suggest this.

@chrisdunelm chrisdunelm added priority: p2+ Type: Enhancement priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2+ labels Jul 14, 2017
@chrisdunelm
Copy link
Contributor

Need to make sure all "claims_supported" from https://accounts.google.com/.well-known/openid-configuration are made available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants