Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalServerCodeReceiver.cs uses 127.0.0.1, which breaks non-admin Windows 7 & 8.1 clients #1055

Closed
chrisdunelm opened this issue Jul 14, 2017 · 1 comment · Fixed by #1063
Closed

LocalServerCodeReceiver.cs uses 127.0.0.1, which breaks non-admin Windows 7 & 8.1 clients #1055

chrisdunelm opened this issue Jul 14, 2017 · 1 comment · Fixed by #1063
Assignees
@chrisdunelm
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
v1.28

Comments

@chrisdunelm
Copy link
Contributor

As reported by @aluxnimm in #987:
This change seems to break Windows 7 and 8.1 clients without admin privileges since HttpListener gets Access Denied for everything except localhost and 127.0.0.1 is only working in Windows 10, see discussion here https://stackoverflow.com/questions/4019466/httplistener-access-denied

We could try "localhost" and fallback to "127.0.0.1" if the HttpListenerException is thrown.
@chrisdunelm chrisdunelm added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 14, 2017
This was referenced Jul 14, 2017
Closed
Closed
@chrisdunelm
Copy link
Contributor Author

Wrong way round. It should try "127.0.0.1" first, then "localhost".

chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Jul 14, 2017
@chrisdunelm
Try both 127.0.0.1 and localhost in the local code receiver
6234eda 
Fixes googleapis#1055
@chrisdunelm chrisdunelm mentioned this issue Jul 14, 2017
Merged
chrisdunelm added a commit that referenced this issue Jul 14, 2017
@chrisdunelm
Try both 127.0.0.1 and localhost in the local code receiver (#1057)
f14fe98 
Fixes #1055
@chrisdunelm chrisdunelm added this to the v1.28 milestone Jul 16, 2017
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Jul 18, 2017
@chrisdunelm
Test for best callback URI; fix hanging browsers
691638b 
Fixes googleapis#540. Really fixes googleapis#1055
@chrisdunelm chrisdunelm mentioned this issue Jul 18, 2017
Merged
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Jul 18, 2017
@chrisdunelm
Test for best callback URI; fix hanging browsers
2420fd8 
Fixes googleapis#540. Really fixes googleapis#1055
chrisdunelm added a commit that referenced this issue Jul 18, 2017
@chrisdunelm
Test for best callback URI; fix hanging browsers (#1063)
46eb0b9 
Fixes #540. Really fixes #1055
@amanda-tarafa amanda-tarafa mentioned this issue Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdunelm chrisdunelm

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
v1.28
Development

Successfully merging a pull request may close this issue.

Test for best callback URI; fix hanging browsers chrisdunelm/google-api-dotnet-client
1 participant
@chrisdunelm