Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case issue for "range" in ResumableUpload class #1114

Closed
Datoh opened this issue Nov 16, 2017 · 1 comment
Closed

Case issue for "range" in ResumableUpload class #1114

Datoh opened this issue Nov 16, 2017 · 1 comment
Assignees
@chrisdunelm
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Datoh
Copy link

Datoh commented Nov 16, 2017 •
edited

Hi,

I upload a file using driveService.File.Create/Upload with the ProgressChanged event. I receive only UploadStatus.Uploading with BytesSent == 0 in the callback.

From my analyze, this due to the fact that the httpResponse for a partial upload use the keyword "range" and in the code, you are looking for the key "Range".

https://github.com/google/google-api-dotnet-client/blob/1f0a6b35ead75ed6f7412142dda596b41bc9347c/Src/Support/Google.Apis/Upload/ResumableUpload.cs#L653

Regards,
Cédric.

PS: When do you plan to have an UWP version for Drive.v3?
@chrisdunelm
Copy link
Contributor

Yes, https://tools.ietf.org/html/rfc7230#section-3.2 states that headers are case-insensitive. I'll get this fixed.

@chrisdunelm chrisdunelm added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 8, 2017
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Dec 8, 2017
@chrisdunelm
Treat range header name as case insensitive
5c62739 
Fixed googleapis#1114
@chrisdunelm chrisdunelm mentioned this issue Dec 8, 2017
Merged
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Dec 8, 2017
@chrisdunelm
Treat range header name as case insensitive
1c51328 
Fixed googleapis#1114
chrisdunelm added a commit that referenced this issue Dec 8, 2017
@chrisdunelm
Treat range header name as case insensitive (#1131)
8427b64 
Fixed #1114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdunelm chrisdunelm

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisdunelm @Datoh