Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationName property isn't validated #729

Closed
mmdriley opened this issue Apr 19, 2016 · 2 comments
Closed

ApplicationName property isn't validated #729

mmdriley opened this issue Apr 19, 2016 · 2 comments
Assignees
@chrisdunelm
Labels
priority: p2+ Type: Enhancement
Milestone
v1.28

Comments

@mmdriley
Copy link
Contributor

The ApplicationName property has to be valid when included in a User-Agent value. We don't validate it eagerly, so users can see a FormatError later when we actually try to construct the request.

We can do the validation with ProductInfoHeaderValue.TryParse.
@chrsmith
Copy link
Contributor

Perhaps this would be a good bug to work with @chrisdunelm to get fixed? So he can learn the dark mysteries of the client libraries?

@chrisdunelm chrisdunelm added this to the v1.27 milestone Apr 24, 2017
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue May 26, 2017
@chrisdunelm
Validate application name
9d49ec2 
Validated on setting in Initializer. Fixes googleapis#729
@chrisdunelm chrisdunelm mentioned this issue May 26, 2017
Merged
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue May 26, 2017
@chrisdunelm
Validate application name
c63ea14 
Validated on setting in Initializer. Fixes googleapis#729.
chrisdunelm added a commit that referenced this issue May 30, 2017
@chrisdunelm
Validate application name (#1019)
a9dbf3d 
Fixes #729.
@chrisdunelm
Copy link
Contributor

Implementation rolled back in #1034 - validation was stricter than required, causing unnecessary validation failures.

@chrisdunelm chrisdunelm reopened this Jun 6, 2017
@chrisdunelm chrisdunelm modified the milestones: v1.28, v1.27 Jun 6, 2017
@chrisdunelm chrisdunelm mentioned this issue Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdunelm chrisdunelm

Labels
priority: p2+ Type: Enhancement
Projects
None yet
Milestone
v1.28
Development

No branches or pull requests
3 participants
@chrisdunelm @mmdriley @chrsmith