New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential improvements #1077

Merged

chrisdunelm merged 2 commits into googleapis:master from chrisdunelm:cred

Aug 30, 2017

Contributor

chrisdunelm commented Aug 24, 2017

Create credentials from file path; and allow scopes to be specified in all relevant credential static factory methods.

If this looks OK, I'll add xmldocs.

Helps with googleapis/google-cloud-dotnet#1398


          Credential improvements

6f24e7b

Create credentials from file path; and allow scopes to be specified in all relevant credential static factory methods.

chrisdunelm assigned jskeet

googlebot added the cla: yes label

Contributor Author

chrisdunelm commented Aug 24, 2017

/cc @SurferJeffAtGoogle

Contributor Author

chrisdunelm commented Aug 24, 2017

@jskeet Please check especially for backward compatibility.

jskeet reviewed

View reviewed changes

Collaborator

jskeet left a comment

Definitely happy with FromFile. Not sure about the scoping parts... maybe see what @SurferJeffAtGoogle thinks?

Src/Support/Google.Apis.Auth/OAuth2/GoogleCredential.cs Outdated

-                      {
-                          return defaultCredentialProvider.GetDefaultCredentialAsync();
-                      }
+                      public static async Task<GoogleCredential> GetApplicationDefaultAsync(IEnumerable<string> scopes) =>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Src/Support/Google.Apis.Auth/OAuth2/GoogleCredential.cs Outdated

                       {
-                          return defaultCredentialProvider.CreateDefaultCredentialFromStream(stream);
+                          using (var f = File.OpenRead(path))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

chrisdunelm commented

View reviewed changes

Contributor Author

chrisdunelm left a comment

I think the scoping part is useful, as it shows that it's important to think about scopes. Currently it's very easy to miss them completely.
Although I agree that as they're only relevant with Service Credentials, it may be that most users don't ever need to think about them!

Src/Support/Google.Apis.Auth/OAuth2/GoogleCredential.cs Outdated

-                      {
-                          return defaultCredentialProvider.GetDefaultCredentialAsync();
-                      }
+                      public static async Task<GoogleCredential> GetApplicationDefaultAsync(IEnumerable<string> scopes) =>

This comment was marked as spam.

Sign in to view

Src/Support/Google.Apis.Auth/OAuth2/GoogleCredential.cs Outdated

                       {
-                          return defaultCredentialProvider.CreateDefaultCredentialFromStream(stream);
+                          using (var f = File.OpenRead(path))

This comment was marked as spam.

Sign in to view

Contributor Author

chrisdunelm commented Aug 24, 2017

Yes, let's see what @SurferJeffAtGoogle thinks.

jskeet mentioned this pull request

It's difficult or impossible to initialize a PublisherClient with a json service account credentials file. googleapis/google-cloud-dotnet#1398

Closed

SurferJeffAtGoogle reviewed

View reviewed changes

Src/Support/Google.Apis.Auth/OAuth2/GoogleCredential.cs Outdated

+                      public static GoogleCredential FromStream(Stream stream, string scope1, params string[] scopes) =>
+                          FromStream(stream, new[] { scope1.ThrowIfNull(nameof(scope1)) }.Concat(scopes.ThrowIfNull(nameof(scopes))));
+                      public static GoogleCredential FromFile(string path, IEnumerable<string> scopes)

This comment was marked as spam.

Sign in to view

SurferJeffAtGoogle reviewed

View reviewed changes

Src/Support/Google.Apis.Auth/OAuth2/GoogleCredential.cs Outdated


		public static Task<GoogleCredential> GetApplicationDefaultAsync() => GetApplicationDefaultAsync(Enumerable.Empty<string>());

		public static Task<GoogleCredential> GetApplicationDefaultAsync(string scope1, params string[] scopes) =>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view


          Remove scoping, add xmldoc

98dbefd

chrisdunelm force-pushed the cred branch from 0410db3 to 98dbefd Compare

August 30, 2017 09:34

jskeet approved these changes

View reviewed changes

chrisdunelm merged commit ebe737d into googleapis:master

chrisdunelm deleted the cred branch

March 16, 2018 17:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment