Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve impersonation support. #2394

Merged
merged 5 commits into from Apr 25, 2023
Merged

feat: Improve impersonation support. #2394

merged 5 commits into from Apr 25, 2023

Commits on Apr 25, 2023

  1. tests: Update the expected error reason for revoking a bad token. 

    Documentation does not specify the exact reason given on each case and this seems to have changed recently.
StatusCode continues to be the same.
See: https://developers.google.com/identity/protocols/oauth2/web-server#httprest_8
    @amanda-tarafa
    amanda-tarafa committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    2bb5020 View commit details
    Browse the repository at this point in the history

  2. feat: ComputeCredential supports impersonation. 

    Closes googleapis#2246
    @amanda-tarafa
    amanda-tarafa committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    6c558e1 View commit details
    Browse the repository at this point in the history

  3. feat: Support impersonated credentials in ADC. 

    Closes googleapis#2363
    @amanda-tarafa
    amanda-tarafa committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    d5d6f39 View commit details
    Browse the repository at this point in the history

  4. chore: Remove googleapis#2159 from backlog as it has been implemented… 

    … in googleapis#2394.
    @amanda-tarafa
    amanda-tarafa committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    de5fe0f View commit details
    Browse the repository at this point in the history

  5. tests: Improvements to DefaultCredentialProvider tests. 

    - Move all dummy credentials to files that are loaded as resources.
- Use Assert.Throws instead of try ... catch.
    @amanda-tarafa
    amanda-tarafa committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    e226361 View commit details
    Browse the repository at this point in the history