feat: Improve SourceLink for NuGet packages #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use deterministic builds - Use a newer version of SourceLink (and centralize it) - Fix issues with unexpected output files - Use a newer version of refernece assemblies (and centralize it) This will generate warnings for Src/Generated projects until we adopt a new version of the generator which doesn't include the reference assemblies and SourceLink package directly.
jskeet
added a commit
to jskeet/gapic-generator-csharp
that referenced
this pull request
Jun 17, 2024
This is the generator counterpart of googleapis/google-api-dotnet-client#2776
|
Fixed b/346943059 |
amanda-tarafa
approved these changes
Jun 17, 2024
jskeet
added a commit
to googleapis/gapic-generator-csharp
that referenced
this pull request
Jun 17, 2024
This is the generator counterpart of googleapis/google-api-dotnet-client#2776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will generate warnings for Src/Generated projects until we adopt a new version of the generator which doesn't include the reference assemblies and SourceLink package directly.