Allow NewtonsoftJsonSerializer to be parameterized with settings. #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chrisdunelm
approved these changes
May 4, 2017
| private readonly JsonSerializerSettings settings; | ||
| private readonly JsonSerializer serializer; | ||
|
|
||
| private static readonly NewtonsoftJsonSerializer instance = new NewtonsoftJsonSerializer(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This allows custom settings such as turning off auto-magic date parsing. (We need to turn this off for the BigQuery wrapper library.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows custom settings such as turning off auto-magic date
parsing. (We need to turn this off for the BigQuery wrapper library.)
(There are some little presentation tidy-ups in the file as well; I could put those into a separate commit if you'd prefer, but they're pretty simple.)