-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idtoken package has been broken since v0.49.0 when service_account credential is used #1092
Labels
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
apstndb
added
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
labels
Jun 28, 2021
apstndb
changed the title
idtoken package shows error when service_account credential is used
idtoken package has broken since v0.49.0 when service_account credential is used
Jun 28, 2021
apstndb
changed the title
idtoken package has broken since v0.49.0 when service_account credential is used
idtoken package has been broken since v0.49.0 when service_account credential is used
Jun 28, 2021
I opened an issue on the docs that is a temporary work around for this: GoogleCloudPlatform/golang-samples#2125 |
Thank you for the report, I will investigate why this is happening. |
This was referenced Jun 29, 2021
codyoss
added
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
and removed
priority: p2
Moderately-important priority. Fix may not be included in next release.
labels
Jun 29, 2021
codyoss
added a commit
that referenced
this issue
Jun 30, 2021
Removed the requirement on length of scopes passed. Checking the EnableJwtWithScope internal option should be sufficient since it will only be passed with our generated clients that will always include at least the platform scope and a default audience. Fixes: #1092
https://github.com/googleapis/google-api-go-client/releases/tag/v0.50.0 includes the fix! |
Hey @codyoss thanks for taking the time to put a fix in :) appreciated. |
Of course! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
Steps to reproduce
Minimal reproducible code.
In
v0.49.0
:In
v0.48.0
, it succeed.It seems to be related with this comment #1075 (comment) and
idtoken
package doesn't specifyWithAudience
.The text was updated successfully, but these errors were encountered: