Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failed when auto-generated codes do not reference the internal package. #1908

Closed
harrisonluo opened this issue Mar 16, 2023 · 0 comments · Fixed by #1909
Closed

Build failed when auto-generated codes do not reference the internal package. #1908

harrisonluo opened this issue Mar 16, 2023 · 0 comments · Fixed by #1909
Assignees
@codyoss
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@harrisonluo
Copy link
Contributor

harrisonluo commented Mar 16, 2023 •
edited

With an empty API, the codes that go_apiary_library build rule generates do not reference the imported internal package. This results in a build error.

This error can be fixed by adding a line that references the internal package, just like the generated codes currently do with a few other packages such as googleapi, internaloption, url, gensuport, io, and json.
@harrisonluo harrisonluo added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 16, 2023
@harrisonluo harrisonluo changed the title Always reference the internal package, in case the auto-generated codes do not. Build failed when auto-generated codes do not reference the internal package. Mar 16, 2023
@harrisonluo harrisonluo mentioned this issue Mar 16, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 17, 2023
@harrisonluo
fix: always reference the internal package. (#1909)
dc4b77d 
In case the auto-generated codes do not.

Fixes #1908
@release-please release-please bot mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: always reference the internal package. harrisonluo/google-api-go-client
2 participants
@harrisonluo @codyoss