feat(option/internaloption): add WithDefaultEndpointTemplate #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add DefaultEndpointTemplate to internal/settings.go * Deprecate internaloption.WithDefaultEndpoint refs: googleapis#2264
shollyman
approved these changes
Dec 18, 2023
codyoss
reviewed
Dec 19, 2023
| @@ -22,10 +22,29 @@ func (o defaultEndpointOption) Apply(settings *internal.DialSettings) { | |||
| // It should only be used internally by generated clients. | |||
| // | |||
| // This is similar to WithEndpoint, but allows us to determine whether the user has overridden the default endpoint. | |||
| // | |||
| // Deprecated: WithDefaultEndpoint does not support setting the universe domain. | |||
There was a problem hiding this comment.
Any reason to not just repurpose this option. I think we could since it is internal?
There was a problem hiding this comment.
I actually plan to use both options simultaneously during a transitional period as universe domain support is incrementally expanded.
There was a problem hiding this comment.
could you do the same thing with one and just check for a %s? I think either way is fine as long as we plan to fully remove the old one eventually
There was a problem hiding this comment.
Definitely plan to remove the old one.
codyoss
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #2264