Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-api-go-generator): add patch for compute mtls endpoint #761

Merged
merged 2 commits into from Dec 2, 2020

Conversation

@andyrzhao
Copy link
Contributor

@andyrzhao andyrzhao commented Nov 23, 2020

Compute discovery doc is currently missing MTLSRootURL since compute discovery doc is generated using old apiary pipeline, and it is not easy to fix. This is expected to be fixed after compute migrates to OP discovery doc gen in 2021. Adding a temporary patch for compute in the meantime. (Compute is the only service that has this issue, among the services we care about for MTLS.) Note that I specifically chose not to add a regex-based generic patch here in order to avoid masking MTLS endpoint issues with other services - if there are any issues, we need to triage them on a case by case basis.

@andyrzhao andyrzhao requested a review from googleapis/yoshi-go-admins as a code owner Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@codyoss
codyoss approved these changes Dec 2, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 445fe0b into googleapis:master Dec 2, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
myusuf3 added a commit to agilebits/google-api-go-client that referenced this pull request Dec 4, 2020
…ogleapis#761)

Compute discovery doc is currently missing MTLSRootURL since compute discovery doc is generated using old apiary pipeline, and it is not easy to fix. This is expected to be fixed after compute migrates to OP discovery doc gen in 2021. Adding a temporary patch for compute in the meantime. (Compute is the only service that has this issue, among the services we care about for MTLS.) Note that I specifically chose not to add a regex-based generic patch here in order to avoid masking MTLS endpoint issues with other services - if there are any issues, we need to triage them on a case by case basis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants