Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): expand OS environment variables in cert provider command #852

Merged
merged 4 commits into from Feb 1, 2021

Conversation

@andyrzhao
Copy link
Contributor

@andyrzhao andyrzhao commented Feb 1, 2021

Environment variables in the cert provider command such as "$HOME" needs to be expanded. This logic was accidentally removed in an earlier patch, so it is being added back now. It impacts scenarios using customized context_aware_metadata.json.

andyrzhao and others added 4 commits Nov 23, 2020
merge from upstream
@andyrzhao andyrzhao requested review from yoshi-approver and googleapis/yoshi-go-admins as code owners Feb 1, 2021
@google-cla google-cla bot added the cla: yes label Feb 1, 2021
@codyoss
codyoss approved these changes Feb 1, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

@codyoss codyoss merged commit be6c56a into googleapis:master Feb 1, 2021
4 checks passed
4 checks passed
@github-actions
auto-approve
Details
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants