-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(byoid): AWS integration test for 3rd party access to Google Client Libraries #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gIthuriel got your other PR merged. After you merge your changes I will take a look at this PR. |
codyoss
requested changes
Apr 26, 2021
9a7ff5a
to
0ee9f2d
Compare
codyoss
requested changes
Apr 26, 2021
codyoss
requested changes
Apr 27, 2021
codyoss
reviewed
Apr 27, 2021
09d13cd
to
f129bd0
Compare
codyoss
reviewed
Apr 27, 2021
d5e9a67
to
8205d8a
Compare
codyoss
approved these changes
Apr 27, 2021
490011f
to
8a69fb6
Compare
d6b5996
to
8a69fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.