Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(byoid): AWS integration test for 3rd party access to Google Client Libraries #987

Merged
merged 15 commits into from
Apr 28, 2021

Conversation

gIthuriel
Copy link
Contributor

No description provided.

@gIthuriel gIthuriel requested review from yoshi-approver and a team as code owners April 20, 2021 20:04
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2021
Copy link
Contributor

@ScruffyProdigy ScruffyProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss
Copy link
Member

codyoss commented Apr 22, 2021

@gIthuriel got your other PR merged. After you merge your changes I will take a look at this PR.

integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Show resolved Hide resolved
integration-tests/byoid/integration_test.go Show resolved Hide resolved
integration-tests/byoid/integration_test.go Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2021
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2021
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@codyoss codyoss merged commit 7449a93 into googleapis:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants