Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep GoogleUtils #1467

Merged
merged 3 commits into from Jan 12, 2020
Merged

keep GoogleUtils #1467

merged 3 commits into from Jan 12, 2020

Conversation

elharo
Copy link
Collaborator

@elharo elharo commented Jan 8, 2020

@elharo elharo requested a review from chingor13 Jan 8, 2020
@elharo elharo requested a review from as a code owner Jan 8, 2020
@googlebot googlebot added the cla: yes label Jan 8, 2020
@elharo
Copy link
Collaborator Author

@elharo elharo commented Jan 9, 2020

so why did this pass locally?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project google-api-client: Compilation failure: Compilation failure:
[ERROR] /tmpfs/src/github/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/GoogleUtils.java:[17,26] error: package androidx.annotation does not exist
[ERROR] /tmpfs/src/github/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/GoogleUtils.java:[34,1] error: cannot find symbol
[ERROR] -> [Help 1]
[ERROR]

@elharo
Copy link
Collaborator Author

@elharo elharo commented Jan 11, 2020

Ping

@elharo elharo merged commit b70e8ef into master Jan 12, 2020
5 of 6 checks passed
@elharo elharo deleted the keep branch Jan 12, 2020
chingor13 added a commit to chingor13/google-api-java-client that referenced this issue Feb 10, 2020
anuraaga added a commit to anuraaga/google-api-java-client that referenced this issue Feb 14, 2020
elharo pushed a commit that referenced this issue Feb 14, 2020
…tation (#1491)

* Revert "keep GoogleUtils (#1467)"

This reverts commit b70e8ef.

* Add proguard resource file to ensure GoogleUtils is kept for Android users.

* Revert "Add google android repository to Gradle instructions (#1489)"

This reverts commit 57a7bb7.

* Restore README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants