chore: update DocFX profile and remove obsolete kokoro configs #2459
Conversation
|
Warning: This pull request is touching the following templated files:
|
| <configuration> | ||
| <executable>bash</executable> | ||
| <arguments> | ||
| <argument>-c</argument> | ||
| <argument><![CDATA[ | ||
| if [ ! -d "play-services" ]; then | ||
| mkdir play-services && | ||
| cd play-services && | ||
| curl --output play-services-basement-8.3.0.aar https://dl.google.com/dl/android/maven2/com/google/android/gms/play-services-basement/8.3.0/play-services-basement-8.3.0.aar && | ||
| unzip play-services-basement-8.3.0.aar && | ||
| mvn install:install-file -Dfile=classes.jar -DgroupId=com.google.android.google-play-services -DartifactId=google-play-services -Dversion=1 -Dpackaging=jar | ||
| fi | ||
| ]]></argument> | ||
| </arguments> | ||
| </configuration> |
There was a problem hiding this comment.
I remember there's a very strange artifact that is not published to Maven Central but available in the dl.google.com site.
There was a problem hiding this comment.
IIRC, it's for the one-time step up to install google-play-services (meant to be done to build locally so we can run build locally): https://github.com/googleapis/google-api-java-client?tab=readme-ov-file#one-time-setup
I don't think it'll break anything, but I'm not sure if we should/need to add it in to the pom. Maybe we can put this behind a profile? Or maybe we can keep it in since it'll save us a step when building locally.
There was a problem hiding this comment.
We need it for the javadoc job to run successfully; this addition is part of the DocFx profile
We have moved the release jobs to Google3. This removes the obsolete kokoro configs.
Javadoc generation has been broken for a while. This updates the DocFx profile such that
mvn javadoc:aggregatecan be run successfully. The other part of this fix will be within g3.Fixes #2458☕️