drive_v3 files.create unable to get resumable session URI #3426
Labels
api: drive
Issues related to the Drive API API.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Feature
I think that would be nice to be able to get the resumable session URI by specifying the uploadType: 'resumable' parameters on the drive_v3 files.create method, instead of doing a POST request.
Motivation
Initially I thought that was the case by reading the documentation on how to perform a resumable upload (link).
So I take a look at the code to understand how to do that but unfortunately it seems impossible.
To summarise the documentation to get a resumable URI we need to do a POST like so:
POST https://www.googleapis.com/upload/drive/v3/files?uploadType=resumable
If we take a look at how the create method it's implemented we found out that we have this URI in to the
mediaUrl
attribute. (link)If we take a look how the request it's constructed we found out that only when we have the
media.body
the correct url it's used. But then theuploadType
it's changed in to something else. So the POST request can't be constructed as desired. (link)Solution
In this case a first simple fix would be modify the createAPIRequestAsync of googleapis-common to add another if statement to enforce the right URI when we have an empty body and the
uploadType
is set to"resumable"
. Pretty much like so:The current solution that I could find instead is to override the URI in the options like so:
Please let me know if i'm missing something or if I should proceed with a pull request on nodejs-googleapis-common repository.
The text was updated successfully, but these errors were encountered: