Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc changes for url shortener example #1013

Merged
merged 7 commits into from Mar 6, 2018
Merged

Doc changes for url shortener example #1013

merged 7 commits into from Mar 6, 2018

Conversation

samaystops4no1
Copy link
Contributor

@samaystops4no1 samaystops4no1 commented Feb 21, 2018

Possibly Fixes #1012.
I have only made a couple of changes in the readme.md file.

P.S: This is my first PR, please correct me if I did anything incorrectly.

  • npm test succeeds
  • Pull request has been squashed into 1 commit
  • I did NOT manually make changes to anything in apis/
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate JSDoc comments were updated in source code (if applicable)
  • Appropriate changes to readme/docs are included in PR

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2018
@samaystops4no1
Copy link
Contributor Author

@JustinBeckwith I merged master branch of my fork into doc_changes_urlshortner_example. That's what I had to do, Right?

@JustinBeckwith JustinBeckwith merged commit e5e95a6 into googleapis:master Mar 6, 2018
@samaystops4no1 samaystops4no1 deleted the doc_changes_urlshortner_example branch March 7, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants