-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: the kitchen sink system test sometimes times out #2020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it really need to be retried, or should we bump the timeout higher? I'm ok with using these retries when the underlying infrastructure is beyond our control, but this feels fairly mechanical.
@JustinBeckwith My experience with similar tests involving |
@JustinBeckwith we can start with bumping the timeout ... what I'd noticed with some of our other tests that have extremely long timeouts, is that there's a lot of variation in how long they take (and their stability). |
Codecov Report
@@ Coverage Diff @@
## master #2020 +/- ##
=======================================
Coverage 38.76% 38.76%
=======================================
Files 6 6
Lines 1068 1068
Branches 8 6 -2
=======================================
Hits 414 414
Misses 654 654 Continue to review full report at Codecov.
|
should be able to use the d.ts
occasionally times out, let's start by retrying it.