Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: the kitchen sink system test sometimes times out #2020

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 7, 2020

should be able to use the d.ts occasionally times out, let's start by retrying it.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2020
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really need to be retried, or should we bump the timeout higher? I'm ok with using these retries when the underlying infrastructure is beyond our control, but this feels fairly mechanical.

@alexander-fenster
Copy link
Contributor

@JustinBeckwith My experience with similar tests involving npm install kind of shows that if it times out, something is going terribly wrong and increasing the timeout won't necessarily help.

@bcoe
Copy link
Contributor Author

bcoe commented Apr 7, 2020

@JustinBeckwith we can start with bumping the timeout ... what I'd noticed with some of our other tests that have extremely long timeouts, is that there's a lot of variation in how long they take (and their stability).

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #2020 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2020   +/-   ##
=======================================
  Coverage   38.76%   38.76%           
=======================================
  Files           6        6           
  Lines        1068     1068           
  Branches        8        6    -2     
=======================================
  Hits          414      414           
  Misses        654      654           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05090da...e711b34. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants