test: use discovery docs from fixture #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
bonus, it looks like this should hopefully fix #2035 too. |
Codecov Report
@@ Coverage Diff @@
## master #2037 +/- ##
=======================================
Coverage 38.82% 38.82%
=======================================
Files 6 6
Lines 1069 1069
Branches 6 6
=======================================
Hits 415 415
Misses 654 654 Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Apr 13, 2020
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than loading discover docs over the wire, which has been proving flaky (I believe turning net connect on and off is the source of the flakes in #2036), use nock to load discovery docs from a fixture.
fixes: #2036, #2035