feat!: run the generator #2053
feat!: run the generator #2053
Conversation
googlebot
added
the
cla: yes
| /** | ||
| * [Optional, Trusted Tester] Deprecated, do not use. Please set hivePartitioningOptions instead. | ||
| */ | ||
| hivePartitioningMode?: string | null; |
There was a problem hiding this comment.
Well, formally, this one, and the type change below, are breaking. Slightly. Kind of.
| /** | ||
| * Baseband version of Android device. | ||
| */ | ||
| basebandVersion?: string | null; |
There was a problem hiding this comment.
All these removals too.
|
I got tired after I read all the way through the letter C, but I would better call it major anyway :) (also, what's up with the CI?) |
|
I have a sneaky suspicion that the |
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
==========================================
+ Coverage 38.82% 38.99% +0.17%
==========================================
Files 6 6
Lines 1069 1072 +3
Branches 8 6 -2
==========================================
+ Hits 415 418 +3
Misses 654 654
Continue to review full report at Codecov.
|
@bcoe @alexander-fenster so this was a wild ride. The root of the test failures had to do with updates in the root url for blogger, which was different in the remote version than the local version. As a result I had to fix the tests and re-run the generator. Hey, no breaking changes this time though!